Page MenuHomePhabricator
Differential D2803

blockfilter: add GCSFilter class
ClosedPublic
Actions

Authored by markblundeberg on Apr 14 2019, 05:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T589: BIP157 & BIP158 backports
Commits
rSTAGING725577a96c74: blockfilter: add GCSFilter class
rABC725577a96c74: blockfilter: add GCSFilter class
Summary

This incorporates six commits from jimpo's PR 12254 for BIP158:

254c85b68 bench: Benchmark GCS filter creation and matching.
f33b717a8 blockfilter: Optimization on compilers with int128 support.
53e7874e0 blockfilter: Simple test for GCSFilter construction and Match.
558c536e3 blockfilter: Implement GCSFilter Match methods.
cf70b5500 blockfilter: Implement GCSFilter constructors.
c454f0ac6 blockfilter: Declare GCSFilter class for BIP 158 impl.

Depends on D2799

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip158c
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5451
Build 8964: Bitcoin ABC Buildbot (legacy)
Build 8963: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Apr 14 2019, 05:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2019, 05:30
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T589: BIP157 & BIP158 backports.Apr 14 2019, 05:31
teamcity added a comment.Apr 14 2019, 05:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 14 2019, 05:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5451: Diff 8050.Apr 14 2019, 05:45
deadalnix requested changes to this revision.Apr 14 2019, 19:33
deadalnix added inline comments.
src/bench/gcs_filter.cpp
13

fix

30

fix

src/blockfilter.h
9

cstdint

13

Include application headers before systems headers

This revision now requires changes to proceed.Apr 14 2019, 19:33
markblundeberg updated this revision to Diff 8053.Apr 14 2019, 23:30
markblundeberg marked 4 inline comments as done.

char eradication and header normalization

teamcity added a comment.Apr 14 2019, 23:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 14 2019, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5453: Diff 8053.Apr 14 2019, 23:45
deadalnix requested changes to this revision.Apr 15 2019, 11:22
deadalnix added inline comments.
src/Makefile.test.include
41 ↗(On Diff #8053)

This must be added to the cmake build.

This revision now requires changes to proceed.Apr 15 2019, 11:22
markblundeberg updated this revision to Diff 8081.Apr 16 2019, 20:38
markblundeberg marked an inline comment as done.

forgot cmakelists for test

teamcity added a comment.Apr 16 2019, 20:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 16 2019, 20:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5472: Diff 8081.Apr 16 2019, 20:53
deadalnix accepted this revision.Apr 16 2019, 22:52
This revision is now accepted and ready to land.Apr 16 2019, 22:52
Closed by commit rABC725577a96c74: blockfilter: add GCSFilter class (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyApr 16 2019, 23:20
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2867: blockfilter: add block filters.Apr 25 2019, 08:57
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING725577a96c74: blockfilter: add GCSFilter class.Sep 18 2019, 22:59

Revision Contents
Changeset List

Diff 8050

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/Makefile.bench.include

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/bench/gcs_filter.cpp

Loading...
View Options

src/blockfilter.h

Loading...
View Options

src/blockfilter.cpp

Loading...
View Options

src/test/blockfilter_tests.cpp

Loading...