Page MenuHomePhabricator
Differential D3585

[1 of 5] util: Move CheckDiskSpace to util.
ClosedPublic
Actions

Authored by markblundeberg on Jul 7 2019, 21:53.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T631: Backport PR 15118 "Refactor block file logic"
Commits
rSTAGINGdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util.
rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util.
Summary

partial PR15118 backport
https://github.com/bitcoin/bitcoin/pull/15118/commits/62e7addb632cad77cbd5fbccbaee51c7b32505d0

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15118a
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6717
Build 11481: Bitcoin ABC Buildbot (legacy)
Build 11480: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 7 2019, 21:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 21:53
teamcity added a comment.Jul 7 2019, 21:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..Jul 7 2019, 21:55
markblundeberg added a task: T631: Backport PR 15118 "Refactor block file logic".Jul 7 2019, 21:56
teamcity added a comment.Jul 7 2019, 22:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6717: Diff 10062.Jul 7 2019, 22:03
jasonbcox accepted this revision.Jul 8 2019, 18:53
This revision is now accepted and ready to land.Jul 8 2019, 18:53
Fabien added inline comments.Jul 8 2019, 20:26
src/util.cpp
207

Nit: move comment above

Closed by commit rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 9 2019, 18:42
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util..Sep 19 2019, 01:06

Revision Contents
Changeset List

PathSize
src/
4 lines
1 line
7 lines
8 lines
36 lines

Diff 10062

View Options

src/init.cpp

Loading...
View Options

src/util.h

Loading...
View Options

src/util.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...