Page MenuHomePhabricator

Merge #13145: Use common getPath method to create temp directory in tests.
ClosedPublic

Authored by markblundeberg on Jul 7 2019, 21:18.

Details

Summary

PR13145 backport https://github.com/bitcoin/bitcoin/pull/13145/files
075429a482 Use common SetDataDir method to create temp directory in tests. (winder)

Pull request description:

Took a stab at #12574

Created a `getPath` method which can be used with the `TestingSetup` fixture to create a temp directory. Updated tests using temp directories to use this method.

I tried setting up a `BOOST_GLOBAL_FIXTURE` to create a truly global path for all tests but was getting linker errors when including `boost/test/unit_test.hpp` in `test_bitcoin.cpp`. Even if I had gotten the linking to work, it looks like `make check` invokes the test binary a bunch of times, so it may not have worked anyway.

Backport note: also updates a validation_tests case (ABC-only, from D199)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 7 2019, 21:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 21:18
Fabien accepted this revision.Jul 8 2019, 07:52
Fabien added inline comments.
src/test/test_bitcoin.cpp
51 ↗(On Diff #10061)

Nit: C++ style constructions instead of C style casts.

This revision is now accepted and ready to land.Jul 8 2019, 07:52
markblundeberg marked an inline comment as done.Jul 8 2019, 14:17