Page MenuHomePhabricator
Differential D199

Fix temporary file creation for validation_tests
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2017, 10:34.

Details

Reviewers
freetrader
sickpig
kyuupichan
awemany
Group Reviewers
Restricted Project
Commits
rSTAGING282d0645a298: Fix temporary file creation for validation_tests
rABC282d0645a298: Fix temporary file creation for validation_tests
Summary

This should hopefully fix the test in validation_tests.cpp
on Windows, where tmpfile() is unusable, at least on travis.

Note for future reference: tmpfile() support seems quite broken on
Windows and should be avoided.

Test Plan

src/test/test_bitcoin -t validation_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

awemany created this revision.Jun 14 2017, 10:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2017, 10:34
Harbormaster completed remote builds in B276: Diff 461.Jun 14 2017, 10:34
deadalnix accepted this revision.Jun 14 2017, 12:38
This revision is now accepted and ready to land.Jun 14 2017, 12:38
freetrader accepted this revision.EditedJun 14 2017, 12:43

Tested ok for me on Linux, will put it through Travis to see about the Windows build.

See:

https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/242820846

deadalnix commandeered this revision.Jun 14 2017, 13:00
deadalnix edited reviewers, added: awemany; removed: deadalnix.
Closed by commit rABC282d0645a298: Fix temporary file creation for validation_tests (authored by awemany, committed by deadalnix). · Explain WhyJun 14 2017, 13:02
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3584: Merge #13145: Use common getPath method to create temp directory in tests..Jul 7 2019, 21:18
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC53d1e61be183: Merge #13145: Use common getPath method to create temp directory in tests..Jul 8 2019, 14:23
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING53d1e61be183: Merge #13145: Use common getPath method to create temp directory in tests..Sep 19 2019, 01:03

Revision Contents
Changeset List

PathSize
src/
test/
10 lines

Diff 464

View Options

src/test/validation_tests.cpp

Loading...