HomePhabricator

Merge #13145: Use common getPath method to create temp directory in tests.

Authored by MarcoFalke <falke.marco@gmail.com> on Jul 12 2018, 11:46.

Description

Merge #13145: Use common getPath method to create temp directory in tests.

Summary:
PR13145 backport https://github.com/bitcoin/bitcoin/pull/13145/files
075429a482 Use common SetDataDir method to create temp directory in tests. (winder)

Pull request description:

Took a stab at #12574

Created a `getPath` method which can be used with the `TestingSetup` fixture to create a temp directory. Updated tests using temp directories to use this method.

I tried setting up a `BOOST_GLOBAL_FIXTURE` to create a truly global path for all tests but was getting linker errors when including `boost/test/unit_test.hpp` in `test_bitcoin.cpp`. Even if I had gotten the linking to work, it looks like `make check` invokes the test binary a bunch of times, so it may not have worked anyway.

Backport note: also updates a validation_tests case (ABC-only, from D199)

Test Plan: make check

Reviewers: deadalnix, Fabien, jasonbcox, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3584

Details