HomePhabricator

Fix temporary file creation for validation_tests
282d0645a298Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix temporary file creation for validation_tests

Summary:
This should hopefully fix the test in validation_tests.cpp
on Windows, where tmpfile() is unusable, at least on travis.

Note for future reference: tmpfile() support seems quite broken on
Windows and should be avoided.

Test Plan: src/test/test_bitcoin -t validation_tests

Reviewers: freetrader, sickpig, kyuupichan, #bitcoin_abc, awemany

Reviewed By: freetrader, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D199

Details

Provenance
awemanyAuthored on Jun 14 2017, 13:00
deadalnixCommitted on Jun 14 2017, 13:02
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D199: Fix temporary file creation for validation_tests
Parents
rSTAGINGde19d18e1c47: Improve test for ReadCompactSize
Branches
Unknown
Tags
Unknown