Page MenuHomePhabricator

Merge #11747: Fix: Open files read only if requested
ClosedPublic

Authored by markblundeberg on Sun, Jul 7, 15:52.

Details

Summary

PR11747 backport https://github.com/bitcoin/bitcoin/pull/11747
e1a8ec5 Fix: Open files read only if requested (Andras Elso)

Note: the PR was closed and an alternate version was merged, see discussion
therein.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Sun, Jul 7, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jul 7, 15:52
deadalnix requested changes to this revision.Mon, Jul 8, 00:48
deadalnix added inline comments.
src/validation.cpp
4308 ↗(On Diff #10052)

This was removed in the PR

This revision now requires changes to proceed.Mon, Jul 8, 00:48
markblundeberg requested review of this revision.Mon, Jul 8, 01:27
markblundeberg added inline comments.
src/validation.cpp
4308 ↗(On Diff #10052)
Fabien accepted this revision.Mon, Jul 8, 06:34
deadalnix accepted this revision.Mon, Jul 8, 12:23
This revision is now accepted and ready to land.Mon, Jul 8, 12:23