Page MenuHomePhabricator
Differential D3579

Merge #11747: Fix: Open files read only if requested
ClosedPublic
Actions

Authored by markblundeberg on Jul 7 2019, 15:52.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe66c645130f0: Merge #11747: Fix: Open files read only if requested
rABCe66c645130f0: Merge #11747: Fix: Open files read only if requested
Summary

PR11747 backport https://github.com/bitcoin/bitcoin/pull/11747
e1a8ec5 Fix: Open files read only if requested (Andras Elso)

Note: the PR was closed and an alternate version was merged, see discussion
therein.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6707
Build 11461: Bitcoin ABC Buildbot (legacy)
Build 11460: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 7 2019, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 15:52
teamcity added a comment.Jul 7 2019, 15:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6707: Diff 10052.Jul 7 2019, 16:02
teamcity added a comment.Jul 7 2019, 16:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a child revision: D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..Jul 7 2019, 21:55
deadalnix requested changes to this revision.Jul 8 2019, 00:48
deadalnix added inline comments.
src/validation.cpp
4308

This was removed in the PR

This revision now requires changes to proceed.Jul 8 2019, 00:48
markblundeberg requested review of this revision.Jul 8 2019, 01:27
markblundeberg added inline comments.
src/validation.cpp
4308

Indeed, but the PR as-is didn't get merged, instead an earlier commit got merged: https://github.com/bitcoin/bitcoin/commit/e1a8ec56c56161be15af1c33067918959e2666de

see: https://github.com/bitcoin/bitcoin/pull/11747#issuecomment-347825814

Fabien accepted this revision.Jul 8 2019, 06:34
deadalnix accepted this revision.Jul 8 2019, 12:23
This revision is now accepted and ready to land.Jul 8 2019, 12:23
Closed by commit rABCe66c645130f0: Merge #11747: Fix: Open files read only if requested (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 8 2019, 13:56
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCe66c645130f0: Merge #11747: Fix: Open files read only if requested.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe66c645130f0: Merge #11747: Fix: Open files read only if requested.Sep 19 2019, 01:02

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 10052

View Options

src/validation.cpp

Loading...