Page MenuHomePhabricator

Merge #10248: Rewrite addrdb with less duplication using CHashVerifier
ClosedPublic

Authored by markblundeberg on Jul 7 2019, 20:08.

Details

Summary

PR10248 backport https://github.com/bitcoin/bitcoin/pull/10248/files
cf68a48 Deduplicate addrdb.cpp and use CHashWriter/Verifier (Pieter Wuille)

backport note: had to add chainParams everywhere due to ABC style; in
turn static had to be removed from one member function so addrdb.h remains
unmodified.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6710
Build 11467: Bitcoin ABC Buildbot (legacy)
Build 11466: arc lint + arc unit

Event Timeline

markblundeberg added inline comments.
src/addrdb.cpp
48

braces

52

braces

57

braces

101

braces

Fabien added inline comments.
src/addrdb.cpp
73 ↗(On Diff #10057)

Revert to uint8_t

This revision is now accepted and ready to land.Jul 8 2019, 07:39