util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded…
378e5385a539
Actions

Description

util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.

Summary:

Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded
NUL characters. Add tests.

Backport of core PR17753.

Depends on D8154.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8155

Details

Provenance

practicalswift <practicalswift@users.noreply.github.com>	Authored on Dec 16 2019, 08:59
Fabien	Committed on Oct 28 2020, 13:57
Fabien	Pushed on Oct 28 2020, 13:58

Reviewer

Restricted Project

Differential Revision

D8155: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.

Parents

rABCbd611af6fa23: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC378e5385a539: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded… (authored by practicalswift <practicalswift@users.noreply.github.com>).Oct 28 2020, 13:57

Fabien added an edge: D8155: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests..

Changes (5)

Path

Size

src/

test/

util/

rABC378e5385a539

View Options

src/test/base32_tests.cpp

View Options

src/test/base64_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/util/moneystr.cpp

View Options

util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded…378e5385a539Actions

Description

Details

Event Timeline

Changes (5)

rABC378e5385a539

src/test/base32_tests.cpp

src/test/base64_tests.cpp

src/test/util_tests.cpp

src/util/moneystr.cpp

src/util/strencodings.cpp

util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded…
378e5385a539
Actions