HomePhabricator

Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in…

Description

Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip

Summary:
fa309dc30579acebff33380abdfe728c1cf59f92 validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (MarcoFalke)

Pull request description:

This change additionally logs the validation state on error, which is not logged at all on current master.

Before:
```
ERROR: ConnectTip(): ConnectBlock ffffff.... failed
```

After:
```
ERROR: ConnectTip: ConnectBlock ffffff.... failed, bad-cb-amount (code 16)
```

Tree-SHA512: e69ee0266772b3f77c0193c4a959c2444bf1a51259bd29d790cf665582b037997e520c8567f70b36362c071dcfe1a8ebd7c0f2286cf1b842df5731960e7e1ba0

Backport of Core PR14097

The test change is not part of the original PR because those error paths diverge on ABC vs Core.

Test Plan:

ninja check
test_runner.py

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5780

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Apr 22 2020, 01:19
jasonbcoxCommitted on Apr 22 2020, 01:22
jasonbcoxPushed on Apr 22 2020, 01:22
Reviewer
Restricted Project
Differential Revision
D5780: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip
Parents
rABCcb75d6b66cc9: gui: Stop translating PACKAGE_NAME
Branches
Unknown
Tags
Unknown