Page MenuHomePhabricator
Differential D5780

Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip
ClosedPublic
Actions

Authored by jasonbcox on Apr 20 2020, 17:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING382f0b28914b: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in…
rABC382f0b28914b: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in…
Summary

fa309dc30579acebff33380abdfe728c1cf59f92 validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (MarcoFalke)

Pull request description:

This change additionally logs the validation state on error, which is not logged at all on current master.

Before:
```
ERROR: ConnectTip(): ConnectBlock ffffff.... failed
```

After:
```
ERROR: ConnectTip: ConnectBlock ffffff.... failed, bad-cb-amount (code 16)
```

Tree-SHA512: e69ee0266772b3f77c0193c4a959c2444bf1a51259bd29d790cf665582b037997e520c8567f70b36362c071dcfe1a8ebd7c0f2286cf1b842df5731960e7e1ba0

Backport of Core PR14097

The test change is not part of the original PR because those error paths diverge on ABC vs Core.

Test Plan
ninja check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 20 2020, 17:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 17:09
teamcity edited the summary of this revision. (Show Details)Apr 20 2020, 17:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 20 2020, 17:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 20 2020, 17:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10307: Diff 18963.Apr 20 2020, 17:33
deadalnix accepted this revision.Apr 20 2020, 17:57
This revision is now accepted and ready to land.Apr 20 2020, 17:57
Closed by commit rABC382f0b28914b: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyApr 22 2020, 01:22
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC382f0b28914b: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in….
jasonbcox added a commit: rSTAGING382f0b28914b: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in….May 5 2020, 19:04

Revision Contents
Changeset List

PathSize
src/
2 lines
test/
functional/
2 lines
2 lines

Diff 19008

View Options

src/validation.cpp

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...