HomePhabricator

[backport#19188] test: Avoid overwriting the NodeContext member of the testing…

Description

[backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field]

Summary:
NodeContext m_node is already a member of BasicTestingSetup which WalletTestingSetup inherits from via TestingSetup

Turns out Core had done this

Backport of Core PR19188

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, Fabien, deadalnix

Reviewed By: #bitcoin_abc, Fabien, deadalnix

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6835

Details

Provenance
majcostaAuthored on Jul 7 2020, 00:45
majcostaPushed on Jul 8 2020, 15:36
Reviewer
Restricted Project
Differential Revision
D6835: [backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field]
Parents
rABC43b890a36ae9: [avalanche] Kill PeerManager::addPeer
Branches
Unknown
Tags
Unknown