Page MenuHomePhabricator

[backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field]
ClosedPublic

Authored by majcosta on Jul 7 2020, 01:09.

Details

Summary

NodeContext m_node is already a member of BasicTestingSetup which WalletTestingSetup inherits from via TestingSetup

Turns out Core had done this

Backport of Core PR19188

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Jul 7 2020, 01:09
Fabien requested changes to this revision.Jul 7 2020, 06:14
Fabien added a subscriber: Fabien.

Please backport PR19188 instead https://github.com/bitcoin/bitcoin/pull/19188

This revision now requires changes to proceed.Jul 7 2020, 06:14
majcosta retitled this revision from [cleanup] remove redundant m_node from wallet_test_fixture.h to [backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field].Jul 7 2020, 16:46
majcosta edited the summary of this revision. (Show Details)

Please update the summary accordingly

This revision is now accepted and ready to land.Jul 8 2020, 08:55