HomePhabricator

Fixed tx padding in rawtransactions.py

Description

Fixed tx padding in rawtransactions.py

Summary:
Fixes tx padding in rawtransactions.py post-fork

Continues T418

Co-authored-by: Dagur Valberg Johannsson <dagurval@pvv.ntnu.no>

Test Plan:
Apply this patch:

diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py
index dfa65aaad..7561b9979 100644
--- a/test/functional/test_framework/util.py
+++ b/test/functional/test_framework/util.py
@@ -336,6 +336,7 @@ def initialize_datadir(dirname, n):
         f.write("rpcport=" + str(rpc_port(n)) + "\n")
         f.write("listenonion=0\n")
         f.write("usecashaddr=1\n")
+        f.write("magneticanomalyactivationtime=1\n")
     return datadir

Then run the test:
./test_runner.py rawtransactions
Running the test fails without the fix and passes with it.

Reviewers: deadalnix, schancel, #bitcoin_abc

Reviewed By: schancel, #bitcoin_abc

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1960

Details

Provenance
jasonbcoxAuthored on Oct 22 2018, 21:28
jasonbcoxPushed on Oct 23 2018, 17:26
Reviewer
Restricted Project
Differential Revision
D1960: Fixed tx padding in rawtransactions.py
Parents
rABCfe9e3923c474: Add cases for parked chain in CheckBlockIndex
Branches
Unknown
Tags
Unknown

Event Timeline

Unknown Object (User) added a subscriber: Unknown Object (User).Jun 4 2020, 10:46
This comment was removed by deadalnix.