Get rid of namespace imports & backporting univalue
41abbec5fd78
Actions

Description

Get rid of namespace imports & backporting univalue

Summary: Remove namespace imports as they pollute namespace and are prone to symbol clashes. Backport univalue to latest version, which also includes namespace removals.

Test Plan: These changes build. No new tests should be necessary.

Reviewers: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Maniphest Tasks: T6

Differential Revision: https://reviews.bitcoinabc.org/D647

Details

Provenance

jasonbcox	Authored on Nov 8 2017, 03:53
jasonbcox	Pushed on Nov 27 2017, 03:32

Reviewer

Restricted Owners Package

Differential Revision

D647: Get rid of namespace imports & backporting univalue

Parents

rABC9034ff1c2dd8: Move the declaration of various json conversion function in rpc/tojson.h

Branches

Unknown

Tags

Unknown

Reverted By

rABC5a035252490c: Revert "Get rid of namespace imports & backporting univalue"

Event Timeline

jasonbcox committed rABC41abbec5fd78: Get rid of namespace imports & backporting univalue (authored by jasonbcox).Nov 27 2017, 03:32

deadalnix mentioned this in D731: Revert "Get rid of namespace imports & backporting univalue".Nov 27 2017, 11:12

deadalnix added a reverting change: rABC5a035252490c: Revert "Get rid of namespace imports & backporting univalue".Nov 27 2017, 11:32

deadalnix mentioned this in rABC5a035252490c: Revert "Get rid of namespace imports & backporting univalue".

Changes (26)

Path

Size

src/

rpc/

univalue/

gen/

include/

lib/

	univalue_get.cpp
	univalue.cpp

test/

	univalue/	test/
		test/

	object.cpp
	univalue_tests.cpp

	src/	univalue/	test/
		contrib/	debian/

	round4.json
	compat

rABC41abbec5fd78

View Options

src/rpc/server.cpp

View Options

src/univalue/.travis.yml

View Options

src/univalue/Makefile.am

View Options

src/univalue/README

View Options

src/univalue/README.md

View Options

src/univalue/configure.ac

View Options

src/univalue/gen/gen.cpp

View Options

src/univalue/include/univalue.h

View Options

src/univalue/lib/univalue.cpp

View Options

src/univalue/lib/univalue_get.cpp

View Options

src/univalue/lib/univalue_read.cpp

View Options

src/univalue/lib/univalue_utffilter.h

View Options

src/univalue/lib/univalue_write.cpp

View Options

src/univalue/test/.gitignore

View Options

src/univalue/test/fail1.json

View Options

src/univalue/test/fail42.json

View Options

src/univalue/test/fail44.json

View Options

src/univalue/test/no_nul.cpp

View Options

src/univalue/test/object.cpp

View Options

src/univalue/test/round3.json

View Options

src/univalue/test/round4.json

View Options

src/univalue/test/round5.json

View Options

src/univalue/test/round6.json

View Options

src/univalue/test/round7.json

View Options

src/univalue/test/test_json.cpp

View Options

src/univalue/test/unitester.cpp

Get rid of namespace imports & backporting univalue41abbec5fd78Actions

Description

Details

Event Timeline

Changes (26)

rABC41abbec5fd78

src/rpc/server.cpp

src/univalue/.travis.yml

src/univalue/Makefile.am

src/univalue/README

src/univalue/README.md

src/univalue/configure.ac

src/univalue/gen/gen.cpp

src/univalue/include/univalue.h

src/univalue/lib/univalue.cpp

src/univalue/lib/univalue_get.cpp

src/univalue/lib/univalue_read.cpp

src/univalue/lib/univalue_utffilter.h

src/univalue/lib/univalue_write.cpp

src/univalue/test/.gitignore

src/univalue/test/fail1.json

src/univalue/test/fail42.json

src/univalue/test/fail44.json

src/univalue/test/no_nul.cpp

src/univalue/test/object.cpp

src/univalue/test/round3.json

src/univalue/test/round4.json

src/univalue/test/round5.json

src/univalue/test/round6.json

src/univalue/test/round7.json

src/univalue/test/test_json.cpp

src/univalue/test/unitester.cpp

Get rid of namespace imports & backporting univalue
41abbec5fd78
Actions