HomePhabricator

Fix uninit values passed into cmov

Description

Fix uninit values passed into cmov

Summary:

  • Fixed UB(arithmetics on uninit values) in cmovs
  • Add valgrind uninit check to cmovs output

This is a backport of libsecp256k1 PR754

Test Plan:

ninja check-secp256k1

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D7589

Details

Provenance
Elichai Turkel <elichai.turkel@gmail.com>Authored on May 20 2020, 12:09
deadalnixCommitted on Sep 27 2020, 22:52
deadalnixPushed on Sep 27 2020, 22:52
Reviewer
Restricted Project
Differential Revision
D7589: Fix uninit values passed into cmov
Parents
rABC83cc25fe22c2: Make ec_ arithmetic more consistent and add documentation
Branches
Unknown
Tags
Unknown