Page MenuHomePhabricator
Differential D7589

Fix uninit values passed into cmov
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 21:47.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC42bcef68620e: Fix uninit values passed into cmov
Summary
  • Fixed UB(arithmetics on uninit values) in cmovs
  • Add valgrind uninit check to cmovs output

This is a backport of libsecp256k1 PR754

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 27 2020, 21:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 21:47
deadalnix requested review of this revision.Sep 27 2020, 21:47
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 21:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12951: Diff 23841.Sep 27 2020, 21:58
deadalnix updated this revision to Diff 23848.Sep 27 2020, 22:12

rebase

Harbormaster completed remote builds in B12954: Diff 23848.Sep 27 2020, 22:22
deadalnix added a child revision: D7590: Recovery signing: add to constant time test, and eliminate non ct operators.Sep 27 2020, 22:26
majcosta accepted this revision.Sep 27 2020, 22:39
This revision is now accepted and ready to land.Sep 27 2020, 22:39
Closed by commit rABC42bcef68620e: Fix uninit values passed into cmov (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain WhySep 27 2020, 22:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC42bcef68620e: Fix uninit values passed into cmov.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
8 lines
4 lines
2 lines
2 lines
2 lines
2 lines
1 line
1 line
1 line
3 lines
11 lines
19 lines

Diff 23859

View Options

src/secp256k1/src/ecmult_const_impl.h

Loading...
View Options

src/secp256k1/src/field.h

Loading...
View Options

src/secp256k1/src/field_10x26_impl.h

Loading...
View Options

src/secp256k1/src/field_5x52_impl.h

Loading...
View Options

src/secp256k1/src/group.h

Loading...
View Options

src/secp256k1/src/scalar.h

Loading...
View Options

src/secp256k1/src/scalar_4x64_impl.h

Loading...
View Options

src/secp256k1/src/scalar_8x32_impl.h

Loading...
View Options

src/secp256k1/src/scalar_low_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/util.h

Loading...