Page MenuHomePhabricator

Improve constant-timeness on PowerPC
ClosedPublic

Authored by deadalnix on Sun, Sep 27, 22:52.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC62fa9a6ee5b0: Improve constant-timeness on PowerPC
Summary
  • Remove redundant "? 1 : 0" after comparisons in scalar code

This prevents GCC from generating branches on PowerPC in certain
cases.

Fixes #771.

  • Suppress a harmless variable-time optimization by clang in _int_cmov

Follow up on 52a03512c1d800603b5c923c1a28bdba12dadb30

This is a backport of libsecp256k1 PR772

Depends on D7590

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sun, Sep 27, 23:09
This revision was landed with ongoing or failed builds.Sun, Sep 27, 23:22
This revision was automatically updated to reflect the committed changes.