Page MenuHomePhabricator

Recovery signing: add to constant time test, and eliminate non ct operators
ClosedPublic

Authored by deadalnix on Sun, Sep 27, 22:26.

Details

Summary
  • Split ecdsa_sign logic into a new function and use it from ecdsa_sign and recovery
  • Add ecdsa_sign_recoverable to the ctime tests
  • Add tests for the cmov implementations

This is a backport of libsecp256k1 PR755

Depends on D7589 and D7587

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sun, Sep 27, 23:00