Page MenuHomePhabricator
Differential D7590

Recovery signing: add to constant time test, and eliminate non ct operators
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 22:26.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC760e82920097: Recovery signing: add to constant time test, and eliminate non ct operators
Summary
  • Split ecdsa_sign logic into a new function and use it from ecdsa_sign and recovery
  • Add ecdsa_sign_recoverable to the ctime tests
  • Add tests for the cmov implementations

This is a backport of libsecp256k1 PR755

Depends on D7589 and D7587

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 27 2020, 22:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 22:26
deadalnix requested review of this revision.Sep 27 2020, 22:27
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 22:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12955: Diff 23849.Sep 27 2020, 22:37
deadalnix added a child revision: D7597: Improve constant-timeness on PowerPC.Sep 27 2020, 22:52
majcosta accepted this revision.Sep 27 2020, 23:00
This revision is now accepted and ready to land.Sep 27 2020, 23:00
Closed by commit rABC760e82920097: Recovery signing: add to constant time test, and eliminate non ct operators (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain WhySep 27 2020, 23:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC760e82920097: Recovery signing: add to constant time test, and eliminate non ct operators.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
modules/
recovery/
39 lines
42 lines
159 lines
14 lines
20 lines

Diff 23864

View Options

src/secp256k1/src/modules/recovery/main_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/util.h

Loading...
View Options

src/secp256k1/src/valgrind_ctime_test.c

Loading...