HomePhabricator

Recovery signing: add to constant time test, and eliminate non ct operators

Description

Recovery signing: add to constant time test, and eliminate non ct operators

Summary:

  • Split ecdsa_sign logic into a new function and use it from ecdsa_sign and recovery
  • Add ecdsa_sign_recoverable to the ctime tests
  • Add tests for the cmov implementations

This is a backport of libsecp256k1 PR755

Depends on D7589 and D7587

Test Plan:

ninja check-secp256k1

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D7590

Details

Provenance
Elichai Turkel <elichai.turkel@gmail.com>Authored on May 26 2020, 21:37
deadalnixCommitted on Sep 27 2020, 23:05
deadalnixPushed on Sep 27 2020, 23:05
Reviewer
Restricted Project
Differential Revision
D7590: Recovery signing: add to constant time test, and eliminate non ct operators
Parents
rABC1f985e5a3bcf: remove dead store in ecdsa_signature_parse_der_lax
Branches
Unknown
Tags
Unknown