HomePhabricator

[core#19724 7/9][refactor] Simplify connection type logic in…

Description

[core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections

Summary:
Consolidate the logic to determine connection type into one conditional to
clarify how they are chosen.

This is a backport of core#19724 [7/9]
https://github.com/bitcoin/bitcoin/pull/19724/commits/4829b6fcc6489b445f80689af6c2a1a919f176b1

Depends on D9775

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9776

Details

Provenance
Amiti Uttarwar <amiti@uttarwar.org>Authored on Aug 14 2020, 04:54
PiRKCommitted on Jul 13 2021, 14:46
PiRKPushed on Jul 13 2021, 14:46
Reviewer
Restricted Project
Differential Revision
D9776: [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections
Parents
rABC74e38fe222eb: [core#19724 6/9][refactor] Simplify check for block-relay-only connection.
Branches
Unknown
Tags
Unknown