HomePhabricator

[SECP256K1] Check if variable=yes instead of if var is set in travis

Description

[SECP256K1] Check if variable=yes instead of if var is set in travis

Summary:

Right now travis.sh checks if VALGRIND and CTIMETEST are set or not, but
in travis.yml we explictly set them to yes so I think it's more
intuitive to check if they're equal to yes such that setting
CTIMETEST=no(or anything other than "yes") will disable the test.

pointed out by @real-or-random here: #696 (comment)

Backport of secp256k1 PR782.

Includes the missing CTIMETEST variable for s390x.

Depends on D7630.

Test Plan: Run the Travis build.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7631

Details

Provenance
Elichai Turkel <elichai.turkel@gmail.com>Authored on Jul 30 2020, 08:18
FabienCommitted on Sep 29 2020, 09:31
FabienPushed on Sep 29 2020, 09:32
Reviewer
Restricted Project
Differential Revision
D7631: [SECP256K1] Check if variable=yes instead of if var is set in travis
Parents
rABCb0c5519ad6d3: [SECP256K1] Make scalar/field choice depend on C-detected __int128 availability
Branches
Unknown
Tags
Unknown