Differential D7631

[SECP256K1] Check if variable=yes instead of if var is set in travis
ClosedPublic
Actions

Authored by Fabien on Sep 29 2020, 09:05.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC46c5de3c85c8: [SECP256K1] Check if variable=yes instead of if var is set in travis

Summary

Right now travis.sh checks if VALGRIND and CTIMETEST are set or not, but
in travis.yml we explictly set them to yes so I think it's more
intuitive to check if they're equal to yes such that setting
CTIMETEST=no(or anything other than "yes") will disable the test.

pointed out by @real-or-random here: #696 (comment)

Backport of secp256k1 PR782.

Includes the missing CTIMETEST variable for s390x.

Depends on D7630.

Test Plan

Run the Travis build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 29 2020, 09:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 09:05

Fabien requested review of this revision.Sep 29 2020, 09:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13007: Diff 23943.Sep 29 2020, 09:13

deadalnix accepted this revision.Sep 29 2020, 09:20

This revision is now accepted and ready to land.Sep 29 2020, 09:20

Closed by commit rABC46c5de3c85c8: [SECP256K1] Check if variable=yes instead of if var is set in travis (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by Fabien). · Explain WhySep 29 2020, 09:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC46c5de3c85c8: [SECP256K1] Check if variable=yes instead of if var is set in travis.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

8 lines

travis/

build_autotools.sh

8 lines

2 lines

Diff 23947

src/secp256k1/.travis.yml

Loading...

src/secp256k1/travis/build_autotools.sh

Loading...

src/secp256k1/travis/build_cmake.sh

Loading...