HomePhabricator

test: Remove MiniWallet mempool_valid option

Description

test: Remove MiniWallet mempool_valid option

Summary:

It seems an unnecessary burden to force MiniWallet call-sites to figure out for each tx whether it is mempool valid or not. The result will only be used for internal sanity checks. So remove the option:

Backport of core#25356.

Depends on D12732.

Note: most tests are not converted to MiniWallet yet, but this change is trivial enough that it's not a problem.

Test Plan:

ninja check-functional

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12733

Details

Provenance
MacroFake <falke.marco@gmail.com>Authored on Jun 13 2022, 12:08
FabienCommitted on Dec 2 2022, 19:49
FabienPushed on Dec 2 2022, 19:49
Reviewer
Restricted Project
Differential Revision
D12733: test: Remove MiniWallet mempool_valid option
Parents
rABC58c2c2568732: test: Return the largest utxo in MiniWallet.get_utxo
Branches
Unknown
Tags
Unknown