Page MenuHomePhabricator
Differential D12733

test: Remove MiniWallet mempool_valid option
ClosedPublic
Actions

Authored by Fabien on Dec 2 2022, 16:15.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC493af7ae840e: test: Remove MiniWallet mempool_valid option
Summary
It seems an unnecessary burden to force MiniWallet call-sites to figure out for each tx whether it is mempool valid or not. The result will only be used for internal sanity checks. So remove the option:

Backport of core#25356.

Depends on D12732.

Note: most tests are not converted to MiniWallet yet, but this change is trivial enough that it's not a problem.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 2 2022, 16:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2022, 16:15
Fabien requested review of this revision.Dec 2 2022, 16:15
teamcity edited the summary of this revision. (Show Details)Dec 2 2022, 16:15
Harbormaster completed remote builds in B21323: Diff 36905.Dec 2 2022, 16:27
sdulfari accepted this revision.Dec 2 2022, 17:10
This revision is now accepted and ready to land.Dec 2 2022, 17:10
sdulfari mentioned this in D12730: test: MiniWallet: skip mempool check if `mempool_valid=False`.Dec 2 2022, 17:10
Fabien added a child revision: D12734: test: use MiniWallet for rpc_scantxoutset.py.Dec 2 2022, 17:13
Closed by commit rABC493af7ae840e: test: Remove MiniWallet mempool_valid option (authored by MacroFake <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 2 2022, 19:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC493af7ae840e: test: Remove MiniWallet mempool_valid option.
PiRK mentioned this in D16021: test: Remove from_node from create_self_transfer* MiniWallet helpers.Apr 19 2024, 10:54
PiRK mentioned this in rABCd0401f334206: test: Remove from_node from create_self_transfer* MiniWallet helpers.Apr 19 2024, 14:47

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines
3 lines
test_framework/
19 lines

Diff 36916

View Options

test/functional/mempool_reorg.py

Loading...
View Options

test/functional/mempool_spend_coinbase.py

Loading...
View Options

test/functional/test_framework/wallet.py

Loading...