Page MenuHomePhabricator
Differential D16021

test: Remove from_node from create_self_transfer* MiniWallet helpers
ClosedPublic
Actions

Authored by PiRK on Apr 19 2024, 10:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd0401f334206: test: Remove from_node from create_self_transfer* MiniWallet helpers
Summary

The from_node argument is no longer used as of D12733

Remove also the unused from_node and wallet arguments in a helper function feature_cltv.py

This is a backport of core#25435

Depends on D16022

Test Plan

ninja check-functional-extended

cmake .. -GNinja -DENABLE_TRACING=1
ninja
sudo ./test/functional/test_runner.py interface_usdt_net
sudo ./test/functional/test_runner.py interface_usdt_utxocache
sudo ./test/functional/test_runner.py interface_usdt_validation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 19 2024, 10:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2024, 10:54
PiRK requested review of this revision.Apr 19 2024, 10:54
teamcity edited the summary of this revision. (Show Details)Apr 19 2024, 10:54
PiRK planned changes to this revision.Apr 19 2024, 10:55

i'm missing a feature_usdt* test

PiRK updated this revision to Diff 47303.Apr 19 2024, 11:21
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)
PiRK added a parent revision: D16022: [test] fix broken interface_usdt_utxocache.py test.

fix also interface_usdt_utxocache

Harbormaster completed remote builds in B28662: Diff 47301.Apr 19 2024, 11:24
Harbormaster completed remote builds in B28664: Diff 47303.Apr 19 2024, 11:46
PiRK added a child revision: D16025: test: add `rescan_utxos` in MiniWallet's initialization.Apr 19 2024, 13:10
Fabien accepted this revision.Apr 19 2024, 13:30
This revision is now accepted and ready to land.Apr 19 2024, 13:30
Closed by commit rABCd0401f334206: test: Remove from_node from create_self_transfer* MiniWallet helpers (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyApr 19 2024, 14:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd0401f334206: test: Remove from_node from create_self_transfer* MiniWallet helpers.

Revision Contents
Changeset List

Diff 47317

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_coinstatsindex.py

Loading...
View Options

test/functional/interface_usdt_utxocache.py

Loading...
View Options

test/functional/mempool_reorg.py

Loading...
View Options

test/functional/mempool_spend_coinbase.py

Loading...
View Options

test/functional/p2p_blocksonly.py

Loading...
View Options

test/functional/test_framework/wallet.py

Loading...