HomePhabricator

[backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction()

Description

[backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction()

Summary:
This refactors the CWalletTx::RelayWalletTransaction() function to be
clearer and adds comments. It also makes two minor behavior
changes:

  • no longer assert if fBroadcastTransactions is false. Just return false

from the function.

  • no longer print the relay message if p2pEnabled is set to false (since

the transaction is not actually relayed).


Backport of Core PR15728

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6406

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Mar 26 2019, 18:56
majcostaCommitted on Jun 6 2020, 12:59
majcostaPushed on Jun 6 2020, 12:59
Reviewer
Restricted Project
Differential Revision
D6406: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction()
Parents
rABC323a3af1e70d: [backport#15452] GetKeyBirthTimes should return key ids, not destinations
Branches
Unknown
Tags
Unknown