Page MenuHomePhabricator

[backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction()
ClosedPublic

Authored by majcosta on Jun 6 2020, 11:08.

Details

Summary

This refactors the CWalletTx::RelayWalletTransaction() function to be
clearer and adds comments. It also makes two minor behavior
changes:

  • no longer assert if fBroadcastTransactions is false. Just return false

from the function.

  • no longer print the relay message if p2pEnabled is set to false (since

the transaction is not actually relayed).


Backport of Core PR15728

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Jun 6 2020, 11:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 6 2020, 12:54