HomePhabricator

Update qt/walletframe.cpp with Qt5 connect syntax

Description

Update qt/walletframe.cpp with Qt5 connect syntax

Summary:
Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-eb1fc130aa1513909d88b42676fde5c7

Depends on D4338

Test Plan:

make check
./bitcoin-qt
Help -> Debug -> Console
createwallet test

In the main window, select the new wallet in the multiwallet drop down

Send -> Receive -> Transactions

Ensure each sub menu loads correctly.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4339

Details

Provenance
nakihitoAuthored on Oct 31 2019, 00:40
nakihitoPushed on Oct 31 2019, 19:29
Reviewer
Restricted Owners Package
Differential Revision
D4339: Update qt/walletframe.cpp with Qt5 connect syntax
Parents
rABC6b8a25d65adb: Update qt/bitcoingui with Qt5 connect syntax
Branches
Unknown
Tags
Unknown