HomePhabricator

[test] improve style for abc-version-message.py and rename to…

Description

[test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py

Summary:

  • Rename the test to be more descriptive, and use an allowed name prefix
  • Respect line length (88 chars)
  • use blocktools.TIME_GENESIS_BLOCK instead of magic number
  • add some documentation
  • replace comments with test logging
  • check the peer id in the debug log

This change is in preparation for a behavior change and additional test in D13357/

Test Plan: ninja check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D13369

Details

Provenance
PiRKAuthored on Mar 17 2023, 07:20
PiRKPushed on Mar 17 2023, 14:42
Reviewer
Restricted Project
Differential Revision
D13369: [test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py
Parents
rABCdc3c7747e18c: refactor: various RecursiveMutex replacements in CConnman
Branches
Unknown
Tags
Unknown