Page MenuHomePhabricator

[test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py
ClosedPublic

Authored by PiRK on Mar 17 2023, 07:52.

Details

Summary
  • Rename the test to be more descriptive, and use an allowed name prefix
  • Respect line length (88 chars)
  • use blocktools.TIME_GENESIS_BLOCK instead of magic number
  • add some documentation
  • replace comments with test logging
  • check the peer id in the debug log

This change is in preparation for a behavior change and additional test in D13357/

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mar 17 2023, 07:52
PiRK retitled this revision from [test] improve style for abc-version-message.py to [test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py.
PiRK edited the summary of this revision. (Show Details)

rename the test

This revision is now accepted and ready to land.Mar 17 2023, 09:46