Page MenuHomePhabricator
Differential D13369

[test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py
ClosedPublic
Actions

Authored by PiRK on Mar 17 2023, 07:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5041cbedc2b9: [test] improve style for abc-version-message.py and rename to…
Summary
  • Rename the test to be more descriptive, and use an allowed name prefix
  • Respect line length (88 chars)
  • use blocktools.TIME_GENESIS_BLOCK instead of magic number
  • add some documentation
  • replace comments with test logging
  • check the peer id in the debug log

This change is in preparation for a behavior change and additional test in D13357/

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 17 2023, 07:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 07:52
PiRK requested review of this revision.Mar 17 2023, 07:52
PiRK mentioned this in D13357: p2p: Don't use timestamps from inbound peers.Mar 17 2023, 07:54
Harbormaster completed remote builds in B22506: Diff 38657.Mar 17 2023, 08:06
PiRK updated this revision to Diff 38661.Mar 17 2023, 09:30
PiRK retitled this revision from [test] improve style for abc-version-message.py to [test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py.
PiRK edited the summary of this revision. (Show Details)

rename the test

Harbormaster completed remote builds in B22510: Diff 38661.Mar 17 2023, 09:43
Fabien accepted this revision.Mar 17 2023, 09:46
This revision is now accepted and ready to land.Mar 17 2023, 09:46
Closed by commit rABC5041cbedc2b9: [test] improve style for abc-version-message.py and rename to… (authored by PiRK). · Explain WhyMar 17 2023, 14:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5041cbedc2b9: [test] improve style for abc-version-message.py and rename to….

Revision Contents
Changeset List

PathSize
test/
functional/
abc_p2p_version_timestamp.py
abc-version-message.py
39 lines
2 lines

Diff 38667

View Options

test/functional/abc-version-message.py

Loading...
View Options

test/functional/abc_p2p_version_timestamp.py

Loading...
View Options

test/functional/test_runner.py

Loading...