HomePhabricator

Do not send (potentially) invalid headers in response to getheaders

Description

Do not send (potentially) invalid headers in response to getheaders

Summary:
Nowhere else in the protocol do we send headers which are for
blocks we have not fully validated except in response to getheaders
messages with a null locator.

Backport of core PR11580

Depends on D2226

Test Plan:

./test/functional/test_runner.py sendheaders

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2227

Details

Provenance
Matt Corallo <git@bluematt.me>Authored on Dec 28 2018, 10:55
FabienCommitted on Jan 6 2019, 10:12
FabienPushed on Jan 6 2019, 10:12
Reviewer
Restricted Project
Differential Revision
D2227: Do not send (potentially) invalid headers in response to getheaders
Parents
rABC50c212c17581: [net] Ignore getheaders requests for very old side blocks
Branches
Unknown
Tags
Unknown