Page MenuHomePhabricator

Do not send (potentially) invalid headers in response to getheaders
ClosedPublic

Authored by Fabien on Dec 27 2018, 22:27.

Details

Summary

Nowhere else in the protocol do we send headers which are for
blocks we have not fully validated except in response to getheaders
messages with a null locator.

Backport of core PR11580

Depends on D2226

Test Plan
./test/functional/test_runner.py sendheaders

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 27 2018, 22:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 27 2018, 22:27
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Dec 30 2018, 18:37
This revision is now accepted and ready to land.Dec 30 2018, 18:37
Closed by commit rABC52adfb10ac25: Do not send (potentially) invalid headers in response to getheaders (authored by Matt Corallo <git@bluematt.me>, committed by Fabien). · Explain WhyJan 6 2019, 10:12
This revision was automatically updated to reflect the committed changes.