Do not send (potentially) invalid headers in response to getheaders
ClosedPublic
Actions

Authored by Fabien on Dec 27 2018, 22:27.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING52adfb10ac25: Do not send (potentially) invalid headers in response to getheaders
rABC52adfb10ac25: Do not send (potentially) invalid headers in response to getheaders

Summary

Nowhere else in the protocol do we send headers which are for
blocks we have not fully validated except in response to getheaders
messages with a null locator.

Backport of core PR11580

Depends on D2226

Test Plan

./test/functional/test_runner.py sendheaders

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 27 2018, 22:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 27 2018, 22:27

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4367: Diff 6427.Dec 27 2018, 22:38

deadalnix accepted this revision.Dec 30 2018, 18:37

This revision is now accepted and ready to land.Dec 30 2018, 18:37

Closed by commit rABC52adfb10ac25: Do not send (potentially) invalid headers in response to getheaders (authored by Matt Corallo <git@bluematt.me>, committed by Fabien). · Explain WhyJan 6 2019, 10:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

33 lines

test/

functional/

sendheaders.py

38 lines

Diff 6524

View Options

src/net_processing.cpp