HomePhabricator

[refactor] clarify tests by referencing p2p objects directly

Description

[refactor] clarify tests by referencing p2p objects directly

Summary:
Use object returned from add_p2p_connection to refer to
p2ps. Add a test class attribute if it needs to be used across
many methods. Don't use the p2p property.

This is a backport of core#19804 [1a/4]
https://github.com/bitcoin/bitcoin/pull/19804/commits/784f757994c1306bb6584b14c0c78617d6248432

abc* test will be done separately.

Test Plan: ninja check-functional-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10320

Details

Provenance
gzhao408 <gzhao408@berkeley.edu>Authored on Sep 4 2020, 01:05
PiRKCommitted on Thu, Oct 14, 11:46
PiRKPushed on Thu, Oct 14, 11:46
Reviewer
Restricted Project
Differential Revision
D10320: [refactor] clarify tests by referencing p2p objects directly
Parents
rABC8b7ad5234871: zmq: Add support to listen on multiple interfaces
Branches
Unknown
Tags
Unknown