Page MenuHomePhabricator

[refactor] clarify tests by referencing p2p objects directly
ClosedPublic

Authored by PiRK on Wed, Oct 13, 07:16.

Details

Summary

Use object returned from add_p2p_connection to refer to
p2ps. Add a test class attribute if it needs to be used across
many methods. Don't use the p2p property.

This is a backport of core#19804 [1a/4]
https://github.com/bitcoin/bitcoin/pull/19804/commits/784f757994c1306bb6584b14c0c78617d6248432

abc* test will be done separately.

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Wed, Oct 13, 07:16
Fabien requested changes to this revision.Wed, Oct 13, 12:46
Fabien added a subscriber: Fabien.

That's not the right commit

This revision now requires changes to proceed.Wed, Oct 13, 12:46
PiRK requested review of this revision.Wed, Oct 13, 15:17
PiRK edited the summary of this revision. (Show Details)

Fixed commit in the description

This revision is now accepted and ready to land.Wed, Oct 13, 15:43