Page MenuHomePhabricator

[refactor] clarify tests by referencing p2p objects directly

Authored by PiRK on Oct 13 2021, 07:16.



Use object returned from add_p2p_connection to refer to
p2ps. Add a test class attribute if it needs to be used across
many methods. Don't use the p2p property.

This is a backport of core#19804 [1a/4]

abc* test will be done separately.

Test Plan

ninja check-functional-extended

Event Timeline

PiRK requested review of this revision.Oct 13 2021, 07:16
Fabien requested changes to this revision.Oct 13 2021, 12:46
Fabien added a subscriber: Fabien.

That's not the right commit

This revision now requires changes to proceed.Oct 13 2021, 12:46
PiRK requested review of this revision.Oct 13 2021, 15:17
PiRK edited the summary of this revision. (Show Details)

Fixed commit in the description

This revision is now accepted and ready to land.Oct 13 2021, 15:43