HomePhabricator

[CMAKE] Fix the prl conversion script library path issue

Authored by Fabien on May 6 2019, 09:28.

Description

[CMAKE] Fix the prl conversion script library path issue

Summary:
The prl conversion script contrib/qt/convert-rpl-libs-to-cmake.pl
determines the library installation directory as being the given library
directory.
While this is true in most cases, it fails with plugins libraries which
are located in their own subtree.
This diff adds a new argument to the perl script so the caller can set
the library directory.

Also adds some quotes surrounding the paths to avoid dealing with issues
with spaces.

Depends on D2947.

Test Plan:

cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake -GNinja \
-DBUILD_BITCOIN_SEEDER=OFF ..
ninja

Check the build is successful

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D2948

Details

Committed
FabienMay 13 2019, 08:07
Pushed
FabienMay 13 2019, 08:07
Reviewer
Restricted Project
Differential Revision
D2948: [CMAKE] Fix the prl conversion script library path issue
Parents
rABC19618b5e6247: Merge #10045: [trivial] Fix typos in comments
Branches
Unknown
Tags
Unknown