[CMAKE] Determine the Qt library directory from a public variable
ClosedPublic
Actions

Authored by Fabien on May 6 2019, 23:27.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING72f4670444b5: [CMAKE] Determine the Qt library directory from a public variable
rABC72f4670444b5: [CMAKE] Determine the Qt library directory from a public variable

Summary

The cmake script currently uses a private variable to get the Qt library
directory. This diffs determines this location from the Qt5Core library
location, avoiding the use of the private variable.
It should have no impact on the build.

Test Plan

cmake -GNinja ..
ninja
./src/qt/bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 6 2019, 23:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2019, 23:27

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2948: [CMAKE] Fix the prl conversion script library path issue.May 6 2019, 23:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5705: Diff 8433.May 6 2019, 23:41

jasonbcox accepted this revision.May 7 2019, 03:39

This revision is now accepted and ready to land.May 7 2019, 03:39

Closed by commit rABC72f4670444b5: [CMAKE] Determine the Qt library directory from a public variable (authored by Fabien). · Explain WhyMay 10 2019, 10:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING72f4670444b5: [CMAKE] Determine the Qt library directory from a public variable.Sep 18 2019, 23:28

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

10 lines

Diff 8589

View Options

[CMAKE] Determine the Qt library directory from a public variableClosedPublicActions