Page MenuHomePhabricator

[CMAKE] Disable OpenGL in Qt static build for OSX
AcceptedPublic

Authored by Fabien on Mon, May 13, 10:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

A bug in the CMake files distributed by Qt prevent building with static
OpenGL on OSX (hard linked dependency to the framework in the Qt5Gui
dependencies). To workaround the issue, the static Qt is built without
the OpenGL support.

This fixes the bitcoin-qt cross build for OSX.

Depends on D3017 and D3033 (for the test plan).

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja

Run the generated src/qt/bitcoin-qt on OSX >= 10.8 (tested on OSX Sierra
10.12.6).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_osx_fix_qt_opengl
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5830
Build 9722: Bitcoin ABC Teamcity Staging
Build 9721: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, May 13, 10:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 13, 10:23
deadalnix accepted this revision.Tue, May 14, 13:22
This revision is now accepted and ready to land.Tue, May 14, 13:22