Page MenuHomePhabricator

[CMAKE] Cleanup the OSX platform file
ClosedPublic

Authored by Fabien on Mon, May 13, 10:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4c604db82bfb: [CMAKE] Cleanup the OSX platform file
Summary

Replace some hardcoded linker flags with CMake built-in variables.
This has no impact to the build.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja -v

Check the linker flags are identical before and after this patch.
Note: the build can fail if the fixes (other diffs) are not landed.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, May 13, 10:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 13, 10:12
deadalnix accepted this revision.Thu, May 16, 16:06
This revision is now accepted and ready to land.Thu, May 16, 16:06
This revision was automatically updated to reflect the committed changes.