Differential D3031

[CMAKE] Cleanup the OSX platform file
ClosedPublic
Actions

Authored by Fabien on May 13 2019, 10:12.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4c604db82bfb: [CMAKE] Cleanup the OSX platform file
rABC4c604db82bfb: [CMAKE] Cleanup the OSX platform file

Summary

Replace some hardcoded linker flags with CMake built-in variables.
This has no impact to the build.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja -v

Check the linker flags are identical before and after this patch.
Note: the build can fail if the fixes (other diffs) are not landed.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 13 2019, 10:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 10:12

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3032: [CMAKE] Fix bitcoind cross build for OSX.May 13 2019, 10:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5827: Diff 8627.May 13 2019, 10:26

deadalnix accepted this revision.May 16 2019, 16:06

This revision is now accepted and ready to land.May 16 2019, 16:06

Closed by commit rABC4c604db82bfb: [CMAKE] Cleanup the OSX platform file (authored by Fabien). · Explain WhyMay 17 2019, 19:55

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in D3018: [CMAKE] Fix CMake cross build for OSX.May 25 2019, 07:15

Fabien added a commit: rSTAGING4c604db82bfb: [CMAKE] Cleanup the OSX platform file.Sep 18 2019, 23:36

Revision Contents
Changeset List

Path

Size

cmake/

platforms/

5 lines

Diff 8722

cmake/platforms/OSX.cmake

Loading...