Page MenuHomePhabricator

[CMAKE] Cleanup the OSX platform file
ClosedPublic

Authored by Fabien on May 13 2019, 10:12.

Details

Summary

Replace some hardcoded linker flags with CMake built-in variables.
This has no impact to the build.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja -v

Check the linker flags are identical before and after this patch.
Note: the build can fail if the fixes (other diffs) are not landed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_osx_cleanup_toolchain_file
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5827
Build 9716: Bitcoin ABC Buildbot (legacy)
Build 9715: arc lint + arc unit