If the QT build is static, add the minimal integration plugin and any
platform specific plugin depending on the target.
Depends on D3091
deadalnix |
Restricted Project |
If the QT build is static, add the minimal integration plugin and any
platform specific plugin depending on the target.
Depends on D3091
mkdir buildcmake && cd buildcmake cmake -GNinja .. ninja ./src/qt/bitcoin-qt
Check that bitcoin-qt runs.
rm -rf * cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
-DBUILD_BITCOIN_SEEDER=OFF ..
ninja
Run the generated bitcoin-qt.exe on a 64 bits Windows.
rm -rf * cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake \
-DBUILD_BITCOIN_SEEDER=OFF ..
ninja
Run the generated bitcoin-qt.exe on a 32 or 64 bits Windows.
Note: OSX build needs another fix to build.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/qt/CMakeLists.txt | ||
---|---|---|
72 ↗ | (On Diff #8593) | The fact you added this here but also felt the need to create a second block based on the exact same check is quite puzzling. |
208 ↗ | (On Diff #8593) | It's not what you are checking for |
221 ↗ | (On Diff #8593) | Presumably, that would need this to happen also if the plugin are not static. |
Move all the static build code into a single section.
Fix comments.
src/qt/CMakeLists.txt | ||
---|---|---|
221 ↗ | (On Diff #8593) | My understanding is that it is not necessary unless you build static. |
src/qt/CMakeLists.txt | ||
---|---|---|
190 ↗ | (On Diff #8622) | Or better concat them then loop |
src/qt/CMakeLists.txt | ||
---|---|---|
27 ↗ | (On Diff #8709) | There are other plateform check down bellow. It's unclear to me why the code is scattered all over the file, especially since you moved a chunk of code because
|
38 ↗ | (On Diff #8709) | This code belong with what was moved down. |
180 ↗ | (On Diff #8709) | That comment doesn't address the code that comes next. |