HomePhabricator

Move Win32 defines to CMakeLists.txt to ensure they are globally defined

Description

Move Win32 defines to CMakeLists.txt to ensure they are globally defined

Summary:

[...]

I'm not aware of any practical effects, but it seems safer to use the
same API versions everywhere.

Backport of core PR15704.

Depends on D7741.

Test Plan:

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7742

Details

Provenance
Luke Dashjr <luke-jr+git@utopios.org>Authored on Aug 21 2017, 14:59
FabienCommitted on Oct 2 2020, 16:38
FabienPushed on Oct 2 2020, 16:39
Reviewer
Restricted Project
Differential Revision
D7742: Move Win32 defines to CMakeLists.txt to ensure they are globally defined
Parents
rABCb969a5330c13: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
Branches
Unknown
Tags
Unknown