Page MenuHomePhabricator
Differential D7742

Move Win32 defines to CMakeLists.txt to ensure they are globally defined
ClosedPublic
Actions

Authored by Fabien on Oct 2 2020, 13:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC53dec441a88e: Move Win32 defines to CMakeLists.txt to ensure they are globally defined
Summary
[...]

I'm not aware of any practical effects, but it seems safer to use the
same API versions everywhere.

Backport of core PR15704.

Depends on D7741.

Test Plan
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 2 2020, 13:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 13:40
Fabien requested review of this revision.Oct 2 2020, 13:40
teamcity edited the summary of this revision. (Show Details)Oct 2 2020, 13:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a child revision: D7743: build: target Windows 7 when building libevent and fix ipv6 usage.Oct 2 2020, 13:41
Harbormaster completed remote builds in B13158: Diff 24207.Oct 2 2020, 13:56
deadalnix accepted this revision.Oct 2 2020, 14:22
This revision is now accepted and ready to land.Oct 2 2020, 14:22
Closed by commit rABC53dec441a88e: Move Win32 defines to CMakeLists.txt to ensure they are globally defined (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by Fabien). · Explain WhyOct 2 2020, 16:39
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC53dec441a88e: Move Win32 defines to CMakeLists.txt to ensure they are globally defined.

Revision Contents
Changeset List

PathSize
src/
11 lines
3 lines
qt/
5 lines
support/
1 line
util/
6 lines

Diff 24218

View Options

src/CMakeLists.txt

Loading...
View Options

src/compat.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/support/lockedpool.cpp

Loading...
View Options

src/util/system.cpp

Loading...