Page MenuHomePhabricator

Move Win32 defines to CMakeLists.txt to ensure they are globally defined
ClosedPublic

Authored by Fabien on Oct 2 2020, 13:40.

Details

Summary
[...]

I'm not aware of any practical effects, but it seems safer to use the
same API versions everywhere.

Backport of core PR15704.

Depends on D7741.

Test Plan
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Event Timeline

Fabien requested review of this revision.Oct 2 2020, 13:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Oct 2 2020, 14:22