HomePhabricator

upnp: add compatibility for miniupnpc 2.2.8

Description

upnp: add compatibility for miniupnpc 2.2.8

Summary:

See: https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f

The return value of 2 now indicates:
"A valid connected IGD has been found but its IP address is reserved (non routable)"

We continue to ignore any return value other than 1.

Backport of core#30283.

Test Plan:
On Arch:

ninja

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16434

Details

Provenance
Cory Fields <cory-nospam-@coryfields.com>Authored on Jun 13 2024, 13:25
FabienCommitted on Jul 9 2024, 15:35
FabienPushed on Jul 9 2024, 15:35
Reviewer
Restricted Project
Differential Revision
D16434: upnp: add compatibility for miniupnpc 2.2.8
Parents
rABCc7154d408c6a: mempool: disallow txns under min relay fee, even in packages
Branches
Unknown
Tags
Unknown