HomePhabricator

mempool: disallow txns under min relay fee, even in packages

Description

mempool: disallow txns under min relay fee, even in packages

Summary:

Note that this still allows packages to bump transactions that are below the dynamic mempool minimum feerate, which means this still solves the "mempool is congested and my presigned 1sat/vB tx is screwed" problem for all transactions.

[...]

Unless we have a DoS-resistant way of ensuring package CPFP-bumped transactions are always bumped, allowing package CPFP to bump below-minrelayfeerate transactions can result in these problematic situations. See #27018 which proposes a partial solution with some limitations, and contains discussion about potential improvements to eviction strategy. While no adequate solution exists, for now, avoid these situations by requiring all transactions to meet min relay feerate.

Backport of core#26933.

Note that the txpackage_tests has to be slightly adjusted to work with our codebase, and the mempool full functional test case has been rewritten to account for the absence of segwit (weight vs size).

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16433

Details

Provenance
FabienAuthored on Jul 9 2024, 08:52
FabienPushed on Jul 9 2024, 15:34
Reviewer
Restricted Project
Differential Revision
D16433: mempool: disallow txns under min relay fee, even in packages
Parents
rABCe5f55cf103b4: [ecash-lib] Support address key in target outputs
Branches
Unknown
Tags
Unknown